Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure _get_entities_with_data_loader is not using the default db session #5314

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Ensure _get_entities_with_data_loader is not using the default db session #5314

merged 1 commit into from
Dec 31, 2024
+113 −2

Conversation

dgarros
Copy link
Collaborator

@dgarros dgarros commented Dec 24, 2024

No description provided.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Dec 24, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 24, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5314 will improve performances by ×2

Comparing dga-20241224-fix-resolver (6f2e640) with stable (5a810b5)

Summary

⚡ 1 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark stable dga-20241224-fix-resolver Change
⚡ test_get_menu 473.5 ms 236.2 ms ×2

@dgarros dgarros force-pushed the dga-20241224-fix-resolver branch from 9adc9cc to 2ba7b3f Compare December 24, 2024 10:18
@dgarros dgarros marked this pull request as ready for review December 24, 2024 10:32
@dgarros dgarros requested a review from a team December 24, 2024 10:32
@dgarros dgarros force-pushed the dga-20241224-fix-resolver branch from 2ba7b3f to 96c143e Compare December 24, 2024 15:55
Base automatically changed from release-1.1 to stable December 30, 2024 18:10
@dgarros dgarros force-pushed the dga-20241224-fix-resolver branch from 96c143e to 2f3f320 Compare December 31, 2024 08:15
@dgarros dgarros added the type/bug Something isn't working as expected label Dec 31, 2024
@dgarros dgarros force-pushed the dga-20241224-fix-resolver branch from 2f3f320 to 6f2e640 Compare December 31, 2024 11:39
@dgarros dgarros merged commit a4311d7 into stable Dec 31, 2024
34 checks passed
@dgarros dgarros deleted the dga-20241224-fix-resolver branch December 31, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajtmccarty ajtmccarty ajtmccarty approved these changes

Assignees
No one assigned
Labels
group/backend Issue related to the backend (API Server, Git Agent) type/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgarros @ajtmccarty